[SciPy-Dev] matlab reading / writing changes - review anyone?

Matthew Brett matthew.brett@gmail....
Thu Nov 11 19:00:29 CST 2010


Hi,

On Tue, Oct 12, 2010 at 8:40 PM, Matthew Brett <matthew.brett@gmail.com> wrote:
>>> I'm sorry - I probably have probably made the comparison a little too
>>> large to be taken in in an instant, but I'd be very grateful for
>>> feedback before merge.
>>
>> Based on a very shallow glance, looks mostly good to me, although:
>>
>> - Using UserWarning sounds a bit nasty -- maybe use
>>  class MatlabReaderWarning(UserWarning): pass instead?
>
> Thanks, good idea.
>
>> - Is there a test for "varmats_from_mat"?
>
> No, only the doctest, thanks for the reminder, I'll put some in.
>
>> - Breaks on Python 3:

Thanks for the review - sorry it took me a little time to python3-ize.
 I believe the tests are passing on 2 and 3 now, and I've added
changes as you suggested, thanks for the review.  Committed : 6871
(and previous)

Cheers,

Matthew


More information about the SciPy-Dev mailing list