[SciPy-Dev] commit rights for Jake Vanderplas

Ralf Gommers ralf.gommers@googlemail....
Thu Feb 2 13:13:17 CST 2012


2012/2/2 Stéfan van der Walt <stefan@sun.ac.za>

> Hey Matthew
>
> On Wed, Feb 1, 2012 at 11:42 PM, Matthew Brett <matthew.brett@gmail.com>
> wrote:
> > I mean - are commit rights for:
> >
> > * making your own commits OR
> > * merging other people's pull requests
> >
> > I think I'm asking the same old git vs svn workflow question.
>
> I think the "policy" for #1 is currently to make a PR, wait for
> feedback, and, if none is forthcoming, to proceed with the merge
> unless you know the change warrants further discussion (think of doc
> fixes, etc).  Essentially, it relies on the good judgement of the
> author.  Ideally, of course, authors shouldn't have to merge their own
> PRs, and Ralf and Warren have been very good at reviewing and merging.
>

Indeed, nothing (except truly trivial things like fixing a typo) should go
in without review. Of course it's still possible to merge your own commits
if another developer has reviewed them and commented that it's OK to do so.

Besides that, I think commit rights are also a kind of recognition for
making significant good quality contributions, and that it's healthy for
scipy to have a larger number of active developers which can review and
merge PRs.

Cheers,
Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/scipy-dev/attachments/20120202/d5c2f8dd/attachment.html 


More information about the SciPy-Dev mailing list