[SciPy-Dev] pull requests and code review

josef.pktd@gmai... josef.pktd@gmai...
Thu Jan 5 18:19:16 CST 2012


Can we keep pull requests open for more than 3 hours, so we actually
have time to look at them.

looking at
https://github.com/scipy/scipy/commit/c9c2d66701583984589c88c08c478e2fc6d9f4ec#L1R1213

my first guess is that the use of inspect.getargspec breaks when the
hessian is a method attached to a class, as we have almost all our
code in statsmodels.
We just fixed a similar case in scipy.

There should be at least time to check whether this kind of suspicions
are justified or not.

Josef


More information about the SciPy-Dev mailing list