[SciPy-Dev] pull requests and code review

Charles R Harris charlesr.harris@gmail....
Thu Jan 5 18:53:46 CST 2012


On Thu, Jan 5, 2012 at 5:41 PM, Travis Oliphant <travis@continuum.io> wrote:

> I don't think there should be any time limit on pull requests.     Who is
> the *we* that needs time to look at them.   I did take time to look at the
> changes.   The code changes were not extensive (except for the very nice
> tests), and it is a welcome change.
>
> Your feedback on the use of inspect is very good.   We can take a look at
> whether or not it method calls were considered and fix it if it does.
>
> If you are interested in continuing to review all the optimize changes, I
> will make sure and give you time to review in the future.    This is where
> having a list of interested and available parties for different modules
> would make a great deal of sense.
>
>
The rule of thumb would be two days for two or three line fixups, a week or
more for more intrusive stuff together with a note to the list. If you need
the code *right now*, then keep developing off line until the whole package
is ready. You'd be surprised at the feedback even "trivial" things can
elicit.

Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/scipy-dev/attachments/20120105/2f4273bf/attachment.html 


More information about the SciPy-Dev mailing list