[SciPy-Dev] Feedback wanted on a couple bug-fix pull requests

Warren Weckesser warren.weckesser@enthought....
Sun Jan 22 14:19:06 CST 2012


On Sat, Jan 7, 2012 at 8:28 AM, Warren Weckesser <
warren.weckesser@enthought.com> wrote:

> Reviews of the following bug fixes would be appreciated:
>
> The linkage function in scipy.cluster has several calls to malloc but the
> return value was not checked. This could result in a segfault when memory
> was low.  This pull request checks the result of each malloc call in the
> function, and raises a MemoryError if it fails:
>     https://github.com/scipy/scipy/pull/110
>
>

I'm still looking for feedback on that pull request.  Anyone interested in
a taking look at some C code?



> signal.lfilter could segfault if given object arrays.  In this pull
> request, that is fixed by checking that all the objects are in fact numbers:
>     https://github.com/scipy/scipy/pull/112
>
>

Travis implemented a better fix for this--thanks, Travis!

Warren
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/scipy-dev/attachments/20120122/3a0c14cf/attachment.html 


More information about the SciPy-Dev mailing list