[SciPy-Dev] cephes_smirnov never returns on mips/sparc/...

josef.pktd@gmai... josef.pktd@gmai...
Fri Mar 30 21:39:01 CDT 2012


On Fri, Mar 30, 2012 at 10:27 PM,  <josef.pktd@gmail.com> wrote:
> On Fri, Mar 30, 2012 at 9:50 PM, Yaroslav Halchenko
> <lists@onerussian.com> wrote:
>> yeap -- that
>>
>> -  if (n <= 0 || e < 0.0 || e > 1.0)
>> +  /* This comparison should assure returning NaN whenever
>> +     e is NaN itself.  In original || form it would proceed */
>> +  if (!(n > 0 && e >= 0.0 && e <= 1.0))
>>
>>
>> resolved the stalling issue and now I am getting the same
>> (1.0, nan, nan) as on x86 ... sent pull request
>>
>> https://github.com/scipy/scipy/pull/187
>>
>> patch is attached here as well
>>
>> so next I guess is to make it return sensible values for the .fit as it did
>> before? ;)
>
> sensible? or starting values?
>
> Fitting now
> [ 1.  0.  1.]
>>>> import scipy
>>>> scipy.__version__
> '0.7.2'
>>>>
>>>> np.__version__
> '1.4.1'

Yaroslav,

Sorry if Debian is getting some noise from my side today. I have
problems paying attention to reply versus reply-all.

Josef

>
> Josef
>
>>
>> On Fri, 30 Mar 2012, Yaroslav Halchenko wrote:
>>
>>> well -- imho it should have not even got to that point if e is
>>> NaN.  Just started rebuilding with following patch:
>>
>>> -  if (n <= 0 || e < 0.0 || e > 1.0)
>>> +  # This comparison should assure returning NaN whenever
>>> +  # e is NaN itself.  In original || form it would proceed
>>> +  if !(n > 0 && e >= 0.0 && e <= 1.0)
>>>      return (NPY_NAN);
>>
>>
>> --
>> =------------------------------------------------------------------=
>> Keep in touch                                     www.onerussian.com
>> Yaroslav Halchenko                 www.ohloh.net/accounts/yarikoptic
>> _______________________________________________
>> SciPy-Dev mailing list
>> SciPy-Dev@scipy.org
>> http://mail.scipy.org/mailman/listinfo/scipy-dev


More information about the SciPy-Dev mailing list