[SciPy-Dev] distributions.py

josef.pktd@gmai... josef.pktd@gmai...
Thu Sep 13 17:48:40 CDT 2012


On Thu, Sep 13, 2012 at 5:21 PM, nicky van foreest <vanforeest@gmail.com> wrote:
> Hi,
>
> Now that I understand github (Thanks to Ralf for his explanations in
> Dutch) and got some simple stuff out of the way in distributions.py I
> would like to tackle a somewhat harder issue. The function argsreduce
> is, as far as I can see, too generic. I did some tests to see whether
> its most generic output, as described by its docstring, is actually
> swallowed by the callers of argsreduce, but this appears not to be the
> case.

being generic is not a disadvantage (per se) if it's fast
https://github.com/scipy/scipy/commit/4abdc10487d453b56f761598e8e013816b01a665
(and a being a one liner is not a disadvantage either)

Josef

>
> My motivation to simplify the code in distributions.py (and clean it
> up) is partly based on making it simpler to understand for myself, but
> also to  others. The fact that github makes code browsing a much nicer
> experience, perhaps more people will take a look at what's under the
> hood. But then the code should also be accessible and clean. Are there
> any reasons not to pursue this path, and focus on more important
> problems of the stats library?
>
> Nicky
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev@scipy.org
> http://mail.scipy.org/mailman/listinfo/scipy-dev


More information about the SciPy-Dev mailing list