[SciPy-Dev] new tests in sparse

Ralf Gommers ralf.gommers@gmail....
Sun Jun 2 15:02:27 CDT 2013


On Fri, May 31, 2013 at 11:49 PM, Blake Griffith <blake.a.griffith@gmail.com
> wrote:

> Hello scipy,
> I'm in the process of adding new tests for sparse matrices with
> dtype=bool, while I'm at it, I thought it would be a good idea to add tests
> for other dtypes. Currently all the tests are for int64 and float64.
>
> There is some canonical data defined in test_base.py. I use this to make
> data with all the supported dtypes. Then I change the tests that use
> this canonical data to iterate over this data with different dtypes
> (including bool).
>
> Does this sound ok? It will make running test_base.py a bit slower. You
> can see my work here:
>

That makes sense to me. Depends on what you mean by "a bit" if it's a
problem that tests run slower. If the test adds more than a few hundred
milliseconds then you should think about what part of those tests have to
be labeled @slow.

Ralf



>
> https://github.com/cowlicks/scipy/commits/official-bool-support
>
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev@scipy.org
> http://mail.scipy.org/mailman/listinfo/scipy-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/scipy-dev/attachments/20130602/ed271c9c/attachment.html 


More information about the SciPy-Dev mailing list