[Scipy-svn] r4578 - branches/Interpolate1D

scipy-svn@scip... scipy-svn@scip...
Tue Jul 29 12:59:54 CDT 2008


Author: fcady
Date: 2008-07-29 12:59:53 -0500 (Tue, 29 Jul 2008)
New Revision: 4578

Modified:
   branches/Interpolate1D/erics_notes.txt
   branches/Interpolate1D/info.py
Log:
edits to TODO.txt

Modified: branches/Interpolate1D/erics_notes.txt
===================================================================
--- branches/Interpolate1D/erics_notes.txt	2008-07-29 17:56:52 UTC (rev 4577)
+++ branches/Interpolate1D/erics_notes.txt	2008-07-29 17:59:53 UTC (rev 4578)
@@ -1,3 +1,7 @@
+*. _remove_bad_data should be left up to the interpolation method if it knows what to do.
+   otherwise, it is handled by this top level class.
+   And, we definitely don't want the list comprehension in the remove_bad_data class.
+
 *. Function signatures:
     
     def interp1d(x, y, new_x, kind='linear', low=np.NaN, high=np.NaN, \
@@ -3,12 +7,12 @@
                         kindkw={}, lowkw={}, highkw={}, \
                         remove_bad_data = False, bad_data=[], interp_axis = 0):
-
-     o. the trailing \ for new lines are not necessary for functions since line continuation
-        is implicit with the open/close parentheses.
-     o. [minor] I would just use NaN instead of np.NaN.  						
+    
      o. It is dangerous to initialize containers as default arguments because they are
         effectively a singleton for the function.  We can discuss this if you don't know
         what I am talking about.
      o. kindkw, lowkw, and highkw aren't really necessary I don't think.  They should go.
+     Xo. [minor] I would just use NaN instead of np.NaN.  						
+     Xo. the trailing \ for new lines are not necessary for functions since line continuation
+        is implicit with the open/close parentheses.
 	 Xo. Do you need both remove_bad_data and bad_data?  If bad_data is None, then you 
 	    don't remove bad_data...
@@ -24,14 +28,6 @@
 	
     def interp1d(x, y, new_x, kind='linear', low=NaN, high=NaN, bad_data=None, axis=-1):
 
-*. _remove_bad_data should be left up to the interpolation method if it knows what to do.
-   otherwise, it is handled by this top level class.
-   And, we definitely don't want the list comprehension in the remove_bad_data class.
-
-X*. I am glad to see your docstrings.
-
-X*. Move tests into a seprate test directory.
-
 X*. Follow scipy/FORMAT_GUIDLINES.txt in the main scipy directory.
 
 For example:
@@ -67,7 +63,10 @@
 	     instead of:
 
 	        def base_class()
+X*. I am glad to see your docstrings.
 
+X*. Move tests into a seprate test directory.
+
 X*. make_array_safe
    I would prefer 'make_array_safe' named atleast_1d_and_contiguous().  This is more specific
    and it is immediately clear to other developers what the check does.  If you add other checks,

Modified: branches/Interpolate1D/info.py
===================================================================
--- branches/Interpolate1D/info.py	2008-07-29 17:56:52 UTC (rev 4577)
+++ branches/Interpolate1D/info.py	2008-07-29 17:59:53 UTC (rev 4578)
@@ -9,7 +9,7 @@
     and extrapolation of 1D (in both input and output) real-valued.  The
     primary function provided is:
 
-        interp1(x, y, new_x) :  from data points (x[i], y[i]), interpolates
+        interp1d(x, y, new_x) :  from data points (x[i], y[i]), interpolates
                                         values for points in new_x and
                                         returns them as an array.  x and new_x
                                         must both be in sorted order.



More information about the Scipy-svn mailing list