[Scipy-svn] r5439 - trunk/scipy/weave

scipy-svn@scip... scipy-svn@scip...
Mon Jan 12 01:29:55 CST 2009


Author: cdavid
Date: 2009-01-12 01:29:52 -0600 (Mon, 12 Jan 2009)
New Revision: 5439

Modified:
   trunk/scipy/weave/build_tools.py
Log:
Do not use close_fds arg of Popen - not supported on windows.

Modified: trunk/scipy/weave/build_tools.py
===================================================================
--- trunk/scipy/weave/build_tools.py	2009-01-12 07:26:09 UTC (rev 5438)
+++ trunk/scipy/weave/build_tools.py	2009-01-12 07:29:52 UTC (rev 5439)
@@ -344,8 +344,8 @@
     result = 0
     cmd = [str(name), '-v']
     try:
-        p = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE,
-                stderr=subprocess.STDOUT, close_fds=True)
+        p = subprocess.Popen(cmd, True, stdout=subprocess.PIPE,
+                stderr=subprocess.STDOUT)
         str_result = p.stdout.read()
         #print str_result
         if 'Reading specs' in str_result:
@@ -364,7 +364,7 @@
     result = 0
     try:
         p = subprocess.Popen(['cl'], shell=True, stdout=subprocess.PIPE,
-                stderr=subprocess.STDOUT, close_fds=True)
+                stderr=subprocess.STDOUT)
         str_result = p.stdout.read()
         #print str_result
         if 'Microsoft' in str_result:
@@ -387,7 +387,7 @@
     def run_command(command):
         """ not sure how to get exit status on nt. """
         p = subprocess.Popen(['cl'], shell=True, stdout=subprocess.PIPE,
-                stderr=subprocess.STDOUT, close_fds=True)
+                stderr=subprocess.STDOUT)
         text = p.stdout.read()
         return 0, text
 else:
@@ -465,7 +465,7 @@
             if self.gcc_version is None:
                 import re
                 p = subprocess.Popen(['gcc', ' -dumpversion'], shell=True,
-                        stdout=subprocess.PIPE, close_fds=True)
+                        stdout=subprocess.PIPE)
                 out_string = p.stdout.read()
                 result = re.search('(\d+\.\d+)',out_string)
                 if result:



More information about the Scipy-svn mailing list