[Scipy-tickets] [SciPy] #1093: signal.hilbert incorrect axis handling for 2d input

SciPy Trac scipy-tickets@scipy....
Sat Jan 16 23:26:23 CST 2010


#1093: signal.hilbert incorrect axis handling for 2d input
--------------------------+-------------------------------------------------
 Reporter:  josefpktd     |       Owner:  somebody    
     Type:  defect        |      Status:  needs_review
 Priority:  normal        |   Milestone:  0.8.0       
Component:  scipy.signal  |     Version:  0.7.0       
 Keywords:                |  
--------------------------+-------------------------------------------------
Changes (by josefpktd):

  * status:  new => needs_review


Old description:

> signal.hilbert returns incorrect results if the input matrix is 2d.
> reported by Ariel Rokim,
> see thread http://mail.scipy.org/pipermail/scipy-
> dev/2010-January/013686.html
>
> The problem is that fft is done with axis=0, ifft is done with default
> axis -1
>
> Proposed fix and enhancement:
>
> * add correct axis statement to all function calls
> * make axis a keyword argument
> * set default axis=-1 to be consistent with usage for fft, this changes
> the API compared to the description in current docstring. However, since
> 2d is currently not working correctly it wouldn't break any existing
> code, since it would be incorrect already.
>
> script with rewritten function and test cases by Ariel are attached

New description:

 signal.hilbert returns incorrect results if the input matrix is 2d.
 reported by Ariel Rokim,
 see thread http://mail.scipy.org/pipermail/scipy-
 dev/2010-January/013686.html

 The problem is that fft is done with axis=0, ifft is done with default
 axis -1

 Proposed fix and enhancement:

  * add correct axis statement to all function calls
  * make axis a keyword argument
  * set default axis=-1 to be consistent with usage for fft, this changes
 the API compared to the description in current docstring. However, since
 2d is currently not working correctly it wouldn't break any existing code,
 since it would be incorrect already.

 script with rewritten function and test cases by Ariel are attached

--

-- 
Ticket URL: <http://projects.scipy.org/scipy/ticket/1093#comment:1>
SciPy <http://www.scipy.org>
SciPy is open-source software for mathematics, science, and engineering.


More information about the Scipy-tickets mailing list