[Scipy-tickets] [SciPy] #902: need high, stop, pass options to signal.firwin

SciPy Trac scipy-tickets@scipy....
Wed Oct 20 06:00:12 CDT 2010


#902: need high, stop, pass options to signal.firwin
----------------------------------+-----------------------------------------
 Reporter:  tpk@…                 |       Owner:  somebody    
     Type:  enhancement           |      Status:  needs_review
 Priority:  normal                |   Milestone:  0.9.0       
Component:  scipy.signal          |     Version:  0.7.0       
 Keywords:                        |  
----------------------------------+-----------------------------------------

Comment(by tpk@…):

 Warren,

 The new file looks good!

 Two comments:

 * defaults

 regarding the default for scale, and the non-linear-phase issue with the
 get_window call, I left those as is because I didn't want to break
 people's code.  Now with the same arguments firwin will generate a
 different filter from before, which can cause problems in code that uses
 the filters.  We can break people's code for the sake of a bug fix which
 one could argue is the case for even length, but I'm not so sure about
 scale as many people could be happy with their scaled filters. At any rate
 the change warrants a mention in the release notes.

 * abs instead of real

 is "s.real" the proper way to normalize the coefficients in the case of
 scaling?  I would have done abs(s) instead, because the response may be
 complex in the center of some arbitrary passband.

-- 
Ticket URL: <http://projects.scipy.org/scipy/ticket/902#comment:14>
SciPy <http://www.scipy.org>
SciPy is open-source software for mathematics, science, and engineering.


More information about the Scipy-tickets mailing list