[Scipy-tickets] [SciPy] #1352: Lomb-Scargle periodogram

SciPy Trac scipy-tickets@scipy....
Tue Jan 25 07:56:29 CST 2011


#1352: Lomb-Scargle periodogram
--------------------------+-------------------------------------------------
 Reporter:  pschella      |       Owner:  somebody    
     Type:  enhancement   |      Status:  needs_review
 Priority:  normal        |   Milestone:  0.10.0      
Component:  Other         |     Version:  0.8.0       
 Keywords:  Lomb-Scargle  |  
--------------------------+-------------------------------------------------
Changes (by rgommers):

  * keywords:  => Lomb-Scargle


Comment:

 Hi Pim,

 I've played with your code a bit, changed a few things, and added it to
 scipy.signal in a github branch: https://github.com/rgommers/scipy/tree
 /lomb-scargle. I think it looks good, whether it really should go into
 signal should be discussed on the mailing list (but seemed like the
 logical place for it).

 About the performance, scaling is quadratic in number of samples, linear
 in number of evaluated frequencies. This seems to be motivated by having
 to implement the algorithm on a GPU, according to Townsend [3]. Wouldn't
 the algorithm in Press and Rybicki
 (http://articles.adsabs.harvard.edu//full/1989ApJ...338..277P/0000277.000.html)
 be faster? It's O(N logN).

 The best name for the module I could think of was spectral_analysis, maybe
 there's a better one? It allows to add similar methods later.

 I think the LaTeX in the docstring should be moved to a tutorial reST doc,
 and only a basic plain text version in the Notes.

 Finally, I suggest to remove the big block of license text, and just
 replace it with a few lines saying you are the original author. The rest
 is just the BSD license, which already applies to all of scipy (see
 LICENSE.txt).

-- 
Ticket URL: <http://projects.scipy.org/scipy/ticket/1352#comment:9>
SciPy <http://www.scipy.org>
SciPy is open-source software for mathematics, science, and engineering.


More information about the Scipy-tickets mailing list