[SciPy-User] Arpack changes from 0.7.2 to 0.8.0

Lutz Maibaum lutz.maibaum@gmail....
Fri Aug 13 15:47:33 CDT 2010


On Aug 11, 2010, at 10:48 AM, josef.pktd@gmail.com wrote:
> On Wed, Aug 11, 2010 at 6:58 AM, ralf.gommers@googlemail.com wrote:
>> 
>> This removal in r5088 made
>>     import scipy.sparse.linalg.eigen.arpack as arpack
>> work, by accident. This was just before the 0.7.x branch was made, so there
>> it worked. The issue is that arpack.py contains a function called eigen, and
>> in eigen/__init__.py there is a line
>>     from arpack import *
>> and then the function gets added to eigen.__all__, which then in turn is
>> imported from one level up.
>> 
>> This looks like a bad idea, so either the module of the function should be
>> renamed. Or the functions in eigen.__all__ should not be made available in
>> the sparse.linalg namespace. But I'd prefer renaming.
> 
> I also think renaming would be the best solution, renaming the module
> wouldn't break the current code (the damage with 0.7 is already done)
> 
> ode is (or was) another case where the class/function shadows the
> module name. The previous reply was that ode should be rewritten. But
> since it doesn't look like that is happening soon, a renaming of the
> shadowed module might a better short tem solution.  (this is from
> memory, I haven't checked recent changes to ode)

Thanks for looking into this. I created a ticket for this issue:

http://projects.scipy.org/scipy/ticket/1263

Best,

  Lutz



More information about the SciPy-User mailing list