[IPython-dev] Heads-up (esp. Thomas) - eyes needed on 74c10b3c

MinRK benjaminrk@gmail....
Sat Apr 14 13:38:04 CDT 2012

On Sat, Apr 14, 2012 at 10:21, Thomas Kluyver <takowl@gmail.com> wrote:

> On 14 April 2012 10:17, Fernando Perez <fperez.net@gmail.com> wrote:
> >
> https://github.com/ipython/ipython/commit/74c10b3c03e377612b54eac8eb19fe0c95930683
> >
> > but I'd like in particular Thomas to have a look in case there's
> > anything specific to our py3 machinery I should/could have done
> > differently.  I think it's OK, but since I don't use py3 regularly, a
> > bit of review would be good (and  in any case, for these kinds of
> > unreviewed emergency commits, post-hoc review is always a good
> > practice).
> We're interpolating a bytes string into a regular string, which
> doesn't quite work as expected:
> commit = "b'816e3fa'"
> We'll need to explicitly decode it first.
> Apart from that, since the file should always be pure ASCII, it should
> be possible to use the built in open() function, rather than
> io.open(), and avoid having to do map(unicode, ...).
> I'll prepare a small PR to add to our stack ;-)

Yes, I imagine just using builtin open and str literals is the right way to
go. No need to deal with unicode for two lines of ascii text.  I just got
carried away with our recently discovery that we should use io.open
everywhere (clearly that excludes setup).

> Thomas
> _______________________________________________
> IPython-dev mailing list
> IPython-dev@scipy.org
> http://mail.scipy.org/mailman/listinfo/ipython-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/ipython-dev/attachments/20120414/67eb9a36/attachment.html 

More information about the IPython-dev mailing list