[Numpy-discussion] Applying Patch #1085
Charles R Harris
charlesr.harris@gmail....
Fri Dec 4 10:09:37 CST 2009
On Fri, Dec 4, 2009 at 6:29 AM, Travis Oliphant <oliphant@enthought.com>wrote:
>
> What do people think of applying patch #1085. This patch makes a copy of
> inputs when the input and output views overlap in ways in which one
> computation will change later computations.
>
>
I'd rename the function views_share_base_data, make the loop to find the
base an inplace function, and break the long lines in the test.
It looks like the routine doesn't try to determine if the views actually
overlap, just if they might potentially share data. Is that correct? That
seems safe and if the time isn't much it might be a nice safety catch. But
it shouldn't go into 1.4.
Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/numpy-discussion/attachments/20091204/c2a9c280/attachment.html
More information about the NumPy-Discussion
mailing list