[Numpy-discussion] Nanmean review
Sun Aug 11 18:10:16 CDT 2013
I have been waiting for a long time to see a nanmean function inside numpy.
I never looked inside this function, but I'm happy seeing this discussion
*Arnaldo D'Amaral Pereira Granja Russo*
Lab. de Estudos dos Oceanos e Clima
Instituto de Oceanografia - FURG
2013/8/10 Ralf Gommers <firstname.lastname@example.org>
> On Sat, Aug 10, 2013 at 12:48 AM, David Reed <email@example.com>wrote:
>> This is my first time contributing and I was hoping to get a review of a
>> change I made. Here is the comparison link.
> Hi David, your contribution looks good and adding nanmean is a good idea.
> However, your code happens to overlap for almost 100% with an already
> submitted pull request: https://github.com/numpy/numpy/pull/3534. I
> suggest that you compare your implementation with the one in PR-3534, and
> maybe you can add an example there or fix some inconsistency.
> This doesn't seem all that consistent by the way. The PR doesn't have an
> example, so I don't know if it behaves the same:
> >>> np.nanmean([1, np.nan, np.inf]) inf
> >>> np.nanmean([1, np.nan, np.inf, np.NINF]) nan
> NumPy-Discussion mailing list
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the NumPy-Discussion