[SciPy-Dev] Deprecate stats.glm?
Thu Jun 3 09:18:02 CDT 2010
> On Thu, Jun 3, 2010 at 8:50 AM, Warren Weckesser
> <firstname.lastname@example.org> wrote:
>> stats.glm looks like it was started and then abandoned without being
>> finished. It was last touched in November 2007. Should this function
>> be deprecated so it can eventually be removed?
> My thoughts when I looked at it was roughly:
> leave it alone since it's working, but don't "advertise" it because we
> should get a better replacement.
How does one not advertise it?
The docstring is wrong, incomplete, and not useful. It has no tests.
Currently, it appears that it just duplicates ttest_ind. As far as I
know, no one is working on it.
Leaving it in wastes users' time reading about it. It erodes confidence
in other functions in scipy: "Is foo() a good function, or has it been
abandoned, like glm()?"
To me, it is an ideal candidate for removal.
> similar to linregress the more general version will be available when
> scipy.stats gets the full OLS model.
>>>> x = (np.arange(20)>9).astype(int)
>>>> y = x + np.random.randn(20)
> (-1.7684287512254859, 0.093933208147769023)
>>>> stats.ttest_ind(y[:10], y[10:])
> (-1.7684287512254859, 0.093933208147768926)
> In the current form it doesn't do much different than ttest_ind except
> for different argument structure.
> I think it could be made to work on string labels if _support.unique
> is replaced by np.unique (which we are doing in statsmodels)
>>>> x = (np.arange(20)>9).astype(str)
> array(['F', 'F', 'F', 'F', 'F', 'F', 'F', 'F', 'F', 'F', 'T', 'T', 'T',
> 'T', 'T', 'T', 'T', 'T', 'T', 'T'],
> Traceback (most recent call last):
> File "<pyshell#24>", line 1, in <module>
> File "C:\Josef\_progs\Subversion\scipy-trunk_after\trunk\dist\scipy-0.8.0.dev6416.win32\Programs\Python25\Lib\site-packages\scipy\stats\stats.py",
> line 3315, in glm
> p = _support.unique(para)
> File "C:\Josef\_progs\Subversion\scipy-trunk_after\trunk\dist\scipy-0.8.0.dev6416.win32\Programs\Python25\Lib\site-packages\scipy\stats\_support.py",
> line 45, in unique
> if np.add.reduce(np.equal(uniques,item).flat) == 0:
> AttributeError: 'NotImplementedType' object has no attribute 'flat'
>> SciPy-Dev mailing list
> SciPy-Dev mailing list
More information about the SciPy-Dev