[SciPy-Dev] pull requests and code review
Thu Jan 5 19:48:25 CST 2012
Understood. I will listen to the feedback --- apologies to those whose toes feel steeped on by the crazy cousin stepping back into the house.
The github process is one I am still not used to in practice. Also, obviously my orientation is towards much faster review cycles which have to happen in industry.
I still think it would be useful to have someplace that people could register their interest in modules. A simple wiki page would be a start, I imagine.
(on a mobile)
On Jan 5, 2012, at 7:27 PM, Charles R Harris <email@example.com> wrote:
> On Thu, Jan 5, 2012 at 6:02 PM, Travis Oliphant <firstname.lastname@example.org> wrote:
> Wow that is a much different time frame than I would expect or think necessary.
> Where does this rule of thumb come from?
> Experience. Think of it as a conference meeting with low bandwidth.
> It has quite a few implications that I don't think are pleasant. I would be quite dissatisfied if my pull requests took 2-3 weeks to get merged.
> Join the crowd.
> Is that just your feeling or does that come from empirical data or a larger vote?
> You just got a complaint, that should tell you something ;)
> You've been out of the loop for a couple of years, you need to take time to feel your way back into things. You may feel that you still own the property but a lot of squatters have moved in while you were gone...
> SciPy-Dev mailing list
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the SciPy-Dev